feat/metric: add new metric for skipper latency#3478
Closed
feat/metric: add new metric for skipper latency#3478
Conversation
This change involves adding a new mtric to measure the overall skipper latency of a request. i.e., the time taken by a request in skipper itself, so this does not include time taken for serving for the response to client and the time taken for the backend round trip. Signed-off-by: speruri <surya.srikar.peruri@zalando.de>
| } | ||
|
|
||
| ctx.setResponse(rsp, p.flags.PreserveOriginal()) | ||
| ctx.backendTime = time.Since(backendStart) |
Contributor
There was a problem hiding this comment.
Lets discuss. It feels like this is collected by two lines below and also it does not have request host dimension (ctx.metricsHost())
Collaborator
Author
|
PR was just to understand the metrics. We can do a proposal to expose different set of metrics |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat/metric: add new metric for skipper latency
This change involves adding a new metric to measure the overall skipper latency of a request. i.e., the time taken by a request in skipper itself, so this does not include time taken for serving for the response to client and the time taken for the backend round trip.