Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved webhook logs documentation with debugging and testing details #763

Open
wants to merge 3 commits into
base: pre-release
Choose a base branch
from

Conversation

ssganesh035
Copy link

  1. Expanded details on webhook request and response attributes.
  2. Added a Debugging Webhook Issues section to help diagnose failures.
  3. Improved readability and structure for better comprehension.

@ssganesh035 ssganesh035 changed the title Improved Webhook Logs Documentation with Debugging and Testing Details Improved webhook logs documentation with debugging and testing details Feb 16, 2025
@ralf401
Copy link
Contributor

ralf401 commented Feb 17, 2025

Hi @ssganesh035,

thanks a lot for your contribution! However, your PR should be slightly tweaked:

  • Please select pre-release as merge target branch
  • Execute a make gettext to update the translation catalog and commit them
  • Rephrase line 30+ to something like:
    Before deploying webhooks in production, you can use testing tools to inspect and debug requests. If you do so, make sure to exclude any sensitive or personal data. And then add the example services.

@ssganesh035 ssganesh035 changed the base branch from 6.2 to pre-release February 21, 2025 10:05
@ssganesh035
Copy link
Author

ssganesh035 commented Feb 21, 2025

Hi @ralf401, hope you are doing well. I have commited the suggested changes, I believe it's good to go now.

@ralf401
Copy link
Contributor

ralf401 commented Feb 24, 2025

Not yet. It seems you just changed the base branch and didn't rebase/update it to the current pre-release branch.

Please do that and make sure to execute the make gettext before committing. The PR may have no conflict before running the CI checks.

Thank you!

@ralf401
Copy link
Contributor

ralf401 commented Mar 10, 2025

Hi @ssganesh035, any news about that? Feel free to rebase and push. Alternatively, I could create a new PR with your suggested changes.

@ssganesh035
Copy link
Author

Hi @ralf401, I will do the needful and update you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants