Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #614 - Adjustments for docker installation #615

Merged
merged 2 commits into from
Mar 7, 2025
Merged

Conversation

ralf401
Copy link
Contributor

@ralf401 ralf401 commented Mar 7, 2025

No description provided.

@ralf401 ralf401 self-assigned this Mar 7, 2025
@ralf401 ralf401 linked an issue Mar 7, 2025 that may be closed by this pull request
Copy link

github-actions bot commented Mar 7, 2025

Artifacts

Produced during runtime

📦 epub-5ee8e1e
📦 html-5ee8e1e
📦 htmlzip-5ee8e1e

@ralf401
Copy link
Contributor Author

ralf401 commented Mar 7, 2025

@mgruner I noticed some things while adding this content to the new docs which I wanted to change. Just some adjustments like moving screenshots and small textual adjustments for the docker stuff so it is now aligned to the new docs. If you would like to have a look feel free. Otherwise I'll just merge and backport it.

Copy link
Contributor

@mgruner mgruner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Regarding the NGINX_EXPOSE_PORT I'm not sure, otoh it's also nice to keep the section clean.

@ralf401 ralf401 merged commit 4fa1b37 into pre-release Mar 7, 2025
1 check passed
@ralf401 ralf401 deleted the rsc/fixes/614 branch March 7, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjustment for Docker Compose / Portainer installation
2 participants