Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdown workflow: include a step using a sed script to remove the added - by stefanzweifel/changelog-updater-action@v1 #20

Merged
merged 11 commits into from
Jun 28, 2023
Merged

Markdown workflow: include a step using a sed script to remove the added - by stefanzweifel/changelog-updater-action@v1 #20

merged 11 commits into from
Jun 28, 2023

Conversation

chicco785
Copy link
Member

@chicco785 chicco785 commented Jun 28, 2023 •
edited
Loading

Description

After tracking the different steps it turns out that the action stefanzweifel/changelog-updater-action@v1 in case of a previous release note including a line like:

- Add workflow to clean-up action cache on PR closure xxxxxxxxxxx (PR #8 by
  @chicco785)

changes the content to:

- Add workflow to clean-up action cache on PR closure xxxxxxxxxxx (PR #8 by
- @chicco785)

so, we remove added - after the action execution

The bug is reported in the original repository stefanzweifel/changelog-updater-action#35, and the workaround can be removed in the future if the issue is solved.

Changes Made

include a step using a sed script to remove the added -.

Related Issues

Fixes #21

Checklist

  • I have used a PR title that is descriptive enough for a release note.
  • I have tested these changes locally.
  • I have added appropriate tests or updated existing tests.
  • I have tested these changes on a dedicated VM or a customer VM [name of the VM]
  • I have added appropriate documentation or updated existing documentation.

@chicco785 chicco785 added the skip-changelog This PR won't be reported in the changelog. label Jun 28, 2023
@chicco785 chicco785 changed the title test release notes include a step using a sed script to remove the added - by `stefanzweifel/changelog-updater-action@v1. Jun 28, 2023
@chicco785 chicco785 marked this pull request as ready for review June 28, 2023 14:28
@chicco785 chicco785 self-assigned this Jun 28, 2023
@chicco785 chicco785 added bug This issue/PR relates to a bug. and removed skip-changelog This PR won't be reported in the changelog. labels Jun 28, 2023
@chicco785 chicco785 changed the title include a step using a sed script to remove the added - by `stefanzweifel/changelog-updater-action@v1. include a step using a sed script to remove the added - by stefanzweifel/changelog-updater-action@v1 Jun 28, 2023
@chicco785 chicco785 merged commit a35a76f into main Jun 28, 2023
5 checks passed
@chicco785 chicco785 deleted the explore-release-note-issue branch June 28, 2023 15:02
@chicco785 chicco785 changed the title include a step using a sed script to remove the added - by stefanzweifel/changelog-updater-action@v1 Markdown workflow: include a step using a sed script to remove the added - by stefanzweifel/changelog-updater-action@v1 Aug 22, 2023
@chicco785 chicco785 changed the title Markdown workflow: include a step using a sed script to remove the added - by stefanzweifel/changelog-updater-action@v1 Markdown workflow: include a step using a sed script to remove the added - by stefanzweifel/changelog-updater-action@v1 Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoPignati MarcoPignati Awaiting requested review from MarcoPignati

Assignees

@chicco785 chicco785

Labels
bug This issue/PR relates to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: the action stefanzweifel/changelog-updater-action@v1 adds - in front of lines starting with @
1 participant
@chicco785