Skip to content

Conversation

nmwafa
Copy link

@nmwafa nmwafa commented Sep 6, 2025

new passive scan script to find js file

@psiinon
Copy link
Member

psiinon commented Sep 6, 2025

Logo
Checkmarx One – Scan Summary & Detailsf8a212fb-7b04-4294-9fc2-8236ec416c7f

Great job! No new security vulnerabilities introduced in this pull request


Communicate with Checkmarx by submitting a PR comment with @Checkmarx followed by one of the supported commands. Learn about the supported commands here.

@psiinon
Copy link
Member

psiinon commented Sep 8, 2025

Is this really a helpful rule?
In my experience apps can reference a lot of JS files. ZAP should find them via spidering so they will be in the Sites Tree. I'm not sure we need Info alerts for them as well.

Review all referenced JavaScript files. Ensure they do not contain sensitive data (e.g., API keys, credentials) and follow secure coding practices.

JS files can be huge so I'm not sure this advice is particularly helpful. It would be much better to implement a rule which actually checked for the sensitive data automatically 😁

@nmwafa
Copy link
Author

nmwafa commented Sep 8, 2025

I think that someone might forget the JS check stage, that's why I made this code. The alert will remind the tester.

It would be much better to implement a rule which actually checked for the sensitive data automatically

Thanks for the suggestion, it's really good. I'll think about making a code for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants