Skip to content

spider: ignore common empty schemes #6782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2025
+7 −2
Merged

spider: ignore common empty schemes #6782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion addOns/spider/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## Unreleased
### Fixed
- Do not warn when canonicalising apparent URI, `//`.
- Do not warn when canonicalising apparent URI, `//`, nor empty `tel` and `mailto`.

## [0.16.0] - 2025-09-02
### Added
Expand Down
5 changes: 4 additions & 1 deletion addOns/spider/src/main/java/org/zaproxy/addon/spider/UrlCanonicalizer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,10 @@ private UrlCanonicalizer() {}
* @return the canonical url
*/
public static String getCanonicalUrl(ParseContext ctx, String url, String baseURL) {
if (StringUtils.startsWithIgnoreCase(url, "javascript:") || "//".equals(url)) {
if (StringUtils.startsWithIgnoreCase(url, "javascript:")
|| StringUtils.startsWithIgnoreCase(url, "tel:")
|| StringUtils.startsWithIgnoreCase(url, "mailto:")
Comment on lines +90 to +91
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

startsWith or equals?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scheme is case insensitive and we don't want any tel/mailto (they were already being ignored when they had values just not empty).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, my question was whether we should use equalsIgnoreCase intead of startsWithIgnoreCase. I wasn't aware that they were already being ignored with values. Makes sense to exist early.

|| "//".equals(url)) {
return null;
}

Expand Down
2 changes: 2 additions & 0 deletions addOns/spider/src/test/java/org/zaproxy/addon/spider/UrlCanonicalizerUnitTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,9 @@ void shouldNormaliseEmptyAndDotPathSegmentsWhenCanonicalizing() {
"javascript:",
"javascript://Something",
"javascript:ignore()",
"mailto:",
"mailto:[email protected]",
"tel:",
"tel:+1-900-555-0191"
})
void shouldIgnoreURIsWithNoAuthority(String uri) {
Expand Down