Skip to content

Use segment 0 instead of return 0 #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use segment 0 instead of return 0 #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 14 additions & 13 deletions Winwheel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1929,22 +1929,23 @@ Winwheel.prototype.getRandomForSegment = function(segmentNumber)
{
let stopAngle = 0;

if (segmentNumber) {
if (typeof this.segments[segmentNumber] !== 'undefined') {
let startAngle = this.segments[segmentNumber].startAngle;
let endAngle = this.segments[segmentNumber].endAngle;
let range = (endAngle - startAngle) - 2;

if (range > 0) {
stopAngle = (startAngle + 1 + Math.floor((Math.random() * range)));
} else {
console.log('Segment size is too small to safely get random angle inside it');
}
if (!segmentNumber) {
console.log('Segment number not specified, use 0 as a fallback value');
segmentNumber = 0;
}

if (typeof this.segments[segmentNumber] !== 'undefined') {
let startAngle = this.segments[segmentNumber].startAngle;
let endAngle = this.segments[segmentNumber].endAngle;
let range = (endAngle - startAngle) - 2;

if (range > 0) {
stopAngle = (startAngle + 1 + Math.floor((Math.random() * range)));
} else {
console.log('Segment ' + segmentNumber + ' undefined');
console.log('Segment size is too small to safely get random angle inside it');
}
} else {
console.log('Segment number not specified');
console.log('Segment ' + segmentNumber + ' undefined');
}

return stopAngle;
Expand Down
Loading