Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix punch dialog for the refactorings which have been done on #102 #115

Merged
merged 6 commits into from
Jul 11, 2024
Merged

Fix punch dialog for the refactorings which have been done on #102 #115

merged 6 commits into from
Jul 11, 2024

Conversation

rodja
Copy link
Member

@rodja rodja commented Jul 11, 2024

This pull request moves the punch dialog into weeding implements to simplify architecture. The get_stretch is the only place where the plant_id is ready available so it makes sense to ask the user there.

pascalzauberzeug
pascalzauberzeug reviewed Jul 11, 2024
View reviewed changes
Copy link
Contributor

@pascalzauberzeug pascalzauberzeug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the change in itself, but noted some small points

field_friend/automations/implements/weeding_implement.py Show resolved Hide resolved
field_friend/automations/navigation/navigation.py Outdated Show resolved Hide resolved
field_friend/automations/implements/weeding_screw.py Outdated Show resolved Hide resolved
field_friend/automations/implements/tornado.py Outdated Show resolved Hide resolved
field_friend/automations/implements/punch_dialog.py Outdated Show resolved Hide resolved
@pascalzauberzeug
Copy link
Contributor

I think you can merge @rodja when you had a look on my changes.

@pascalzauberzeug pascalzauberzeug added this to the 0.2.0 milestone Jul 11, 2024
@pascalzauberzeug pascalzauberzeug added the enhancement New feature or request label Jul 11, 2024
@rodja rodja merged commit b24ca73 into relevant-weeds Jul 11, 2024
1 check passed
@rodja rodja deleted the punch-dialog branch July 11, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@falkoschindler falkoschindler falkoschindler left review comments

@pascalzauberzeug pascalzauberzeug pascalzauberzeug approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@rodja @pascalzauberzeug @falkoschindler