Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make plant positions Point3d #169

Merged
merged 3 commits into from
Sep 5, 2024
Merged

Make plant positions Point3d #169

merged 3 commits into from
Sep 5, 2024

Conversation

pascalzauberzeug
Copy link
Contributor

We need 3d positions for plants for 3d cameras, this PR adds this for all cameras with default z=0

@pascalzauberzeug pascalzauberzeug added the enhancement New feature or request label Sep 3, 2024
@pascalzauberzeug pascalzauberzeug added this to the 0.3.0 milestone Sep 3, 2024
@LukasBaecker LukasBaecker marked this pull request as ready for review September 4, 2024 14:05
@pascalzauberzeug
Copy link
Contributor Author

All tests pass. We can't test it on a robot right now, but the only important thing would the projection from the camera image. That should work, because the projection was 3d anyway.

@pascalzauberzeug pascalzauberzeug merged commit 916d5a2 into main Sep 5, 2024
1 check passed
@pascalzauberzeug pascalzauberzeug deleted the 3d_plants branch September 5, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants