Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make a enable on startup param #175

Merged
merged 1 commit into from
Sep 6, 2024
Merged

make a enable on startup param #175

merged 1 commit into from
Sep 6, 2024

Conversation

Johannes-Thiel
Copy link
Contributor

on f15 enable on startup does not work. This is a work around.

@Johannes-Thiel Johannes-Thiel added this to the 0.3.0 milestone Sep 6, 2024
LukasBaecker
LukasBaecker approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@LukasBaecker LukasBaecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. Would prever:

.get('enable_esp_on_startup', False)

instead of if/else but I think it is a question of code-style.

@LukasBaecker LukasBaecker merged commit 556b289 into main Sep 6, 2024
2 of 3 checks passed
@LukasBaecker LukasBaecker deleted the enable-on-startup branch September 6, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasBaecker LukasBaecker LukasBaecker approved these changes

@pascalzauberzeug pascalzauberzeug Awaiting requested review from pascalzauberzeug

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Johannes-Thiel @LukasBaecker