Field Creation Wizard and Field Class Changes

[LukasBaecker]

In the course of planning the new field navigation #180 , the wizard for creating fields will be updated and will be accessible from the start page (the field_planner will be deactivated temporary). In addition, fields will be saved differently from now on. Only the AB line and a few field parameters will be saved persistently. Rows and the perimeter of the field will from now on be calculated dynamically from the parameters. For now we concentrate on only one field for one robot. Also, obstacles will be added in future and are neglected.

Todos:

• update Field Creation Wizard and move it to the main page
• update Field class (save needed params and calculate rows and boundary)
• deactivate field_planner
• visualize the field in leaflet
• fix rows and boundary calculation issue
• update tests

[rodja]

I just had a short glance at the PR, but want to share some thoughts:

• code which we not use anymore should be removed not left in a comment (we have git to not loose code)
• I find it quite hard to differentiate between Field and FieldParameters; I think the code would get much simpler if we simply had a Field with first_row_start, first_row_end, row_spacing, and row_countwhich are persistent. Whenever they change we would call an internal method_refreshwhich updates the non-persistent propertiesrowsandpoints`.
• There are still some leftovers like obstacle property in Field which we do not need (yet).

[LukasBaecker]

I just had a short glance at the PR, but want to share some thoughts:

• code which we not use anymore should be removed not left in a comment (we have git to not loose code)
• I find it quite hard to differentiate between Field and FieldParameters; I think the code would get much simpler if we simply had a Field with first_row_start, first_row_end, row_spacing, and row_countwhich are persistent. Whenever they change we would call an internal method_refreshwhich updates the non-persistent propertiesrowsandpoints`.
• There are still some leftovers like obstacle property in Field which we do not need (yet).

I have made changes according to your feedback.

Now there seems to be an error when creating a field. The first field is created correctly, but the following ones have errors in the calculation of the rows and the perimeter, which I need to solve.

[LukasBaecker]

I just had a short glance at the PR, but want to share some thoughts:

• code which we not use anymore should be removed not left in a comment (we have git to not loose code)
• I find it quite hard to differentiate between Field and FieldParameters; I think the code would get much simpler if we simply had a Field with first_row_start, first_row_end, row_spacing, and row_countwhich are persistent. Whenever they change we would call an internal method_refreshwhich updates the non-persistent propertiesrowsandpoints`.
• There are still some leftovers like obstacle property in Field which we do not need (yet).

I have made changes according to your feedback.

Now there seems to be an error when creating a field. The first field is created correctly, but the following ones have errors in the calculation of the rows and the perimeter, which I need to solve.

Fixed.

Applied changes according to your feedback.

[pascalzauberzeug]

Tested on F13, approved!