Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the need for gnss pausing #189

Merged
merged 25 commits into from
Oct 22, 2024
Merged

Remove the need for gnss pausing #189

merged 25 commits into from
Oct 22, 2024

Conversation

pascalzauberzeug
Copy link
Contributor

@pascalzauberzeug pascalzauberzeug commented Sep 30, 2024

Based on the findings in #177, we decided to remove the gnss pausing and automaticly update when the robot didn't move between gnss signals.

Note on the movement check:
Before it was check whether both poses are equal, which will not work with small movement / sensor noise and time differences between both poses.
The tolerance values are arbitrarily picked, but should work alright.

if self.last_robot_pose == self.odometer.prediction:

vs

if abs(distance) > 0.0001 or yaw_difference > np.deg2rad(0.01): # if robot does not stand still

@pascalzauberzeug pascalzauberzeug added the enhancement New feature or request label Sep 30, 2024
@pascalzauberzeug pascalzauberzeug added this to the 0.4.0 milestone Sep 30, 2024
@pascalzauberzeug pascalzauberzeug changed the title Remove the need gnss pausing Remove the need for gnss pausing Sep 30, 2024
@pascalzauberzeug pascalzauberzeug marked this pull request as ready for review October 12, 2024 23:49
rodja
rodja previously requested changes Oct 14, 2024
field_friend/localization/gnss.py Outdated Show resolved Hide resolved
@pascalzauberzeug pascalzauberzeug removed this from the 0.4.0 milestone Oct 18, 2024
@pascalzauberzeug pascalzauberzeug added this to the 0.5.0 milestone Oct 18, 2024
@pascalzauberzeug
Copy link
Contributor Author

Tested on F13, will merge now

@pascalzauberzeug pascalzauberzeug merged commit ecf53cc into main Oct 22, 2024
1 check passed
@pascalzauberzeug pascalzauberzeug deleted the remove_gnss_pausing branch October 22, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants