-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the need for gnss pausing #189
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalzauberzeug
changed the title
Remove the need gnss pausing
Remove the need for gnss pausing
Sep 30, 2024
rodja
previously requested changes
Oct 14, 2024
Closed
LukasBaecker
approved these changes
Oct 22, 2024
Co-authored-by: LukasBaecker <[email protected]>
Tested on F13, will merge now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the findings in #177, we decided to remove the gnss pausing and automaticly update when the robot didn't move between gnss signals.
Note on the movement check:
Before it was check whether both poses are equal, which will not work with small movement / sensor noise and time differences between both poses.
The tolerance values are arbitrarily picked, but should work alright.
field_friend/field_friend/automations/automation_watcher.py
Line 133 in ef427b8
vs
field_friend/field_friend/localization/gnss.py
Line 109 in a2378a2