add Automation time tracking #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At the moment the time is in seconds, we should talk about the correct format of the data. |
|
The tracking was moved to the base implement. The unnecessary Kpis were removed and are no longer shown in the UI. |
pascalzauberzeug
previously requested changes
Oct 13, 2024
Comment on lines
63
to
66
| self.start_time = rosys.time() | ||
| self.start_time = rosys.time() | ||
| self.start_time = rosys.time() | ||
| self.start_time = rosys.time() |
There was a problem hiding this comment.
Suggested change
| self.start_time = rosys.time() | |
| self.start_time = rosys.time() | |
| self.start_time = rosys.time() | |
| self.start_time = rosys.time() | |
| self.start_time = rosys.time() |
What happened here? 😄
There was a problem hiding this comment.
I Have no idea 😄
|
maybe we could put this tracking into the navigation? |
LukasBaecker
requested changes
Oct 16, 2024
Comment on lines
79
to
96
| def increment_all_time_kpi(self, indicator: str) -> None: | ||
| self.increment(indicator) | ||
| if getattr(self.all_time_kpis, indicator) is None: | ||
| new_value = 1 | ||
| else: | ||
| new_value = getattr(self.all_time_kpis, indicator)+1 | ||
| setattr(self.all_time_kpis, indicator, new_value) | ||
| self.invalidate() | ||
| return | ||
|
|
||
| def get_time_kpi(self) -> str: | ||
| total_seconds = self.all_time_kpis.time | ||
| hours = total_seconds // 3600 | ||
| minutes = (total_seconds % 3600) // 60 | ||
| seconds = total_seconds % 60 | ||
| return f'{hours:02}:{minutes:02}:{seconds:02}' | ||
|
|
||
| def increment_weeding_kpi(self, indicator: str) -> None: |
There was a problem hiding this comment.
I would rather increment by a given value because the passed time is not always exactly 1 second.
Comment on lines
11
to
13
| def __init__(self, name: str, system:'System') -> None: | ||
| self.name = name | ||
| self.system = system |
Comment on lines
24
to
30
|
|
||
| async def prepare(self) -> bool: | ||
| return True | ||
|
|
||
| async def finish(self) -> None: | ||
| await super().finish() | ||
|
|
| @@ -49,6 +49,8 @@ def __init__(self, plant_provider: PlantProvider) -> None: | |||
| self.WEEDING_KPIS_UPDATED = rosys.event.Event() | |||
| """one of the KPIs of the running weeding automation has been updated.""" | |||
|
|
|||
| self.all_time_kpis: KPIs = KPIs() | |||
There was a problem hiding this comment.
The other KPIs can be deleted due to their inactivity.
LukasBaecker
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a Timetracker. But it seams to be used for Time on a specific field.
I made a tracker to track all the time in automations. This Tacker works for all weeding implements and the Recorder. It can be seen in the status drawer.