Support Points for Specific Rows #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR need to be tested on a real system but beside that everything is ready to review. |
pascalzauberzeug
previously requested changes
Oct 21, 2024
Co-authored-by: Pascal Schade <[email protected]>
Co-authored-by: Pascal Schade <[email protected]>
|
@LukasBaecker I took the liberty to make |
LukasBaecker
dismissed
pascalzauberzeug’s stale review
all changes reviewed and applied
|
Tested successfully on F13, will merge now |
pascalzauberzeug
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the rows of a field are calculated with the first row (the AB-line), the row-spacing and the number of rows. This PR adds the ability to set support points for a single line that does not fit the given row-spacing.
Example:
The created field has a AB-line a row spacing of 50cm and 10 rows. Though, the spacing between the fourth and fifth row is 70cm. By placing the robot on the fifth row and adding a support point for this row the calculation of all 10 rows now includes the support points. The following rows are based on the position of the fifth row but with the given row-spacing of 50cm.
adding support point dialog
store support points in field
calcultate rows with support points
calculate boundary based on these novel rows
reset a support point for a specific row that already has a support point
write tests
test on a real system