Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log status changes #47

Merged
merged 3 commits into from
Dec 6, 2024
Merged

log status changes #47

merged 3 commits into from
Dec 6, 2024

Conversation

denniswittich
Copy link
Contributor

No description provided.

NiklasNeugebauer
NiklasNeugebauer requested changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@NiklasNeugebauer NiklasNeugebauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these are not needed since they are defined in the parent class.

learning_loop_node/detector/detector_node.py Outdated Show resolved Hide resolved
learning_loop_node/trainer/trainer_node.py Outdated Show resolved Hide resolved
NiklasNeugebauer
NiklasNeugebauer reviewed Dec 5, 2024
View reviewed changes
Copy link
Contributor

@NiklasNeugebauer NiklasNeugebauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise

@denniswittich denniswittich merged commit f28d540 into main Dec 6, 2024
3 checks passed
@denniswittich denniswittich deleted the log-changing-status-updates branch December 6, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiklasNeugebauer NiklasNeugebauer NiklasNeugebauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denniswittich @NiklasNeugebauer