-
-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table cell slot without string template #3261
base: main
Are you sure you want to change the base?
Table cell slot without string template #3261
Conversation
@falkoschindler Hi, I have already completed the basic functionality implementation. I will set aside time later to write tests and documentation. However, I encountered numerous challenges during the implementation process.
|
Ok, thanks, @CrystalWindSnake! Just let me known when you think it's a good time for a first code review. 🙂 |
I've been quite busy with work recently, and I expect to need another two days to complete the unit tests. After that, I'll ask for your review, thanks. |
@CrystalWindSnake are you still able to get this done? @wasabismile and others would greatly benefit from this. See #3484 (comment). |
@rodja This approach encounters difficulties with ui.table. ui.table refreshes at certain moments, such as when switching pages or when the screen size changes, and after refreshing, the content of Teleport disappears. The following example should demonstrate the issue. from nicegui import ui
columns = [
{"name": "name", "label": "Product", "field": "name", "align": "center"},
{"name": "sales", "label": "Sales", "field": "sales", "align": "center"},
]
rows = [
{"name": "A", "data": [10, 8, 2, 4]},
{"name": "B", "data": [3, 5, 7, 8]},
{"name": "C", "data": [2, 1, 3, 7]},
]
table = ui.table(columns=columns, rows=rows, row_key="name", pagination=2).classes(
"w-72"
)
for r, row in enumerate(rows):
with ui.teleport(f"#c{table.id} tr:nth-child({r+1}) td:nth-child(2)"):
ui.echart(
{
"xAxis": {"type": "category", "show": False},
"yAxis": {"type": "value", "show": False},
"series": [{"type": "line", "data": row["data"]}],
}
).classes("w-44 h-20")
ui.run() This example is largely identical to Example, with the sole modification being the setting of I have not found an easy solution to detect when |
@CrystalWindSnake @falkoschindler table.on('update:pagination', lambda _: ui.run_javascript('location.reload();')) Maybe this method is not very good, I still hope that more people can use the table cell slot as soon as possible. |
In addition to refreshing the pagination, there are other refresh issues to consider. I'll work on implementing the basic functions gather some examples of the problems over the next few days, and then submit a PR. We can discuss how to address other refresh problems after that. |
When I use the latest version of NiceGUI, the issues I encountered before have disappeared. Vue 3.5 may have resolved a series of problems with |
@CrystalWindSnake Issue #3939 just reminded me of this PR. Are you still working on it? Is there anything we can do to help? Your last update sounded very promising. |
@falkoschindler I'm sorry. I've been busy with other things recently and haven't had much time to focus on this. |
This PR is based on discussion #3148. The goal is to table cell slots without writing any Vue string templates.