Skip to content

Conversation

evnchn
Copy link
Collaborator

@evnchn evnchn commented May 31, 2025

Motivation

Addresses NiceGUI Wishlist (view)

Implementation

  • As mentioned, QPageScroller is very similar to QPageSticky, so we copy over the code and the function signature from ui.page_sticky
  • Then, we add on the 3 new properties, scroll-offset, reverse and duration, inheriting the default values of 300ms duration and 1000ms scroll-offset from Quasar.
  • Reworked the documentation, because the old one was so messy and hard to read.

Progress

  • I chose a meaningful title that completes the sentence: "If applied, this PR will..."
  • The implementation is complete.
  • Pytests have been added (or are not necessary).
  • Documentation has been added (or is not necessary).

-> No pytest for ui.page_sticky so no pytest for ui.page_scroller too.

@evnchn evnchn added feature Type/scope: New feature or enhancement review Status: PR is open and needs review ⚪️ minor Priority: Low impact, nice-to-have labels May 31, 2025
@falkoschindler falkoschindler self-requested a review May 31, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Type/scope: New feature or enhancement ⚪️ minor Priority: Low impact, nice-to-have review Status: PR is open and needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant