Fix hierarchy scroll-to for mobile situation #4824
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
While working on another PR, I noticed that the NiceGUI documentation kept throwing errors in the console, and I realized that the scroll-into-view functionality never worked for mobile users, since the DOM is not populated until the tree is expanded.
Implementation
?.
such that it doesn't throw an error, instead fails silently.Progress
Results
Before:
-> Wrong scroll position, errors thrown
After:
-> Correct scroll position, no errors