Feat: fps
and show_stats
for ui.scene
#4825
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
While working on #4820, I noticed that the FPS of NiceGUI's
ui.scene
is low. I originally though it was Three.js performance issue, but their demo's running at a smooth 120FPS, so I thought what gives?As it turns out, it's hard-coded to 20FPS (
requestAnimationFrame(() => setTimeout(() => render(), 1000 / 20));
)While we're at it, added on the
Stats
module fromThree.js
to visualize difference.Implementation
fps
propStats
module fromThree.js
to visualize difference.npm.json
Progress
-> Pytest should be unnecessary, otherwise the testing load may be huge.