Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spending pool selection #1244

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

nuttycom
Copy link
Contributor

@nuttycom nuttycom commented Mar 9, 2024

Builds on #1243

@nuttycom nuttycom force-pushed the spending_pool_selection branch from e68c5e7 to 94b4719 Compare March 9, 2024 06:08
Copy link

codecov bot commented Mar 9, 2024

Codecov Report

Attention: Patch coverage is 68.91892% with 46 lines in your changes are missing coverage. Please review.

Project coverage is 64.84%. Comparing base (58f46e4) to head (547e00e).

Files Patch % Lines
zcash_client_sqlite/src/wallet.rs 55.17% 26 Missing ⚠️
zcash_client_backend/src/data_api.rs 62.16% 14 Missing ⚠️
zcash_client_backend/src/data_api/error.rs 0.00% 3 Missing ⚠️
zcash_client_sqlite/src/lib.rs 70.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1244      +/-   ##
==========================================
- Coverage   64.91%   64.84%   -0.08%     
==========================================
  Files         117      117              
  Lines       12818    12922     +104     
==========================================
+ Hits         8321     8379      +58     
- Misses       4497     4543      +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nuttycom nuttycom force-pushed the spending_pool_selection branch 2 times, most recently from c883bf4 to eb198e0 Compare March 9, 2024 17:40
@nuttycom nuttycom force-pushed the spending_pool_selection branch 2 times, most recently from 050813a to 422f8ab Compare March 9, 2024 17:44
@nuttycom nuttycom force-pushed the spending_pool_selection branch from 422f8ab to 9683813 Compare March 9, 2024 20:19
@nuttycom nuttycom marked this pull request as draft March 12, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant