Set the default optimization level to 3 for testing #1443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to disable this. (As well as the fact that much of our code essentially requires optimization to run at all reasonably, this ensures that we are testing the code as it is compiled for release builds.) Signed-off-by: Daira-Emma Hopwood <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1443 +/- ##
=======================================
Coverage 63.22% 63.22%
=======================================
Files 128 128
Lines 14865 14865
=======================================
Hits 9398 9398
Misses 5467 5467 ☔ View full report in Codecov by Sentry. |
str4d
reviewed
Jul 9, 2024
| @@ -123,6 +123,10 @@ lto = true | |||
| panic = 'abort' | |||
| codegen-units = 1 | |||
|
|
|||
| [profile.test] | |||
| opt-level = 3 | |||
There was a problem hiding this comment.
We should experiment with Cargo profile overrides to just optimize the math-heavy dependencies: https://docs.rust-embedded.org/book/unsorted/speed-vs-size.html#optimizing-dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
--profile=devto disable this. (As well as the fact that much of our code essentially requires optimization to run at all reasonably, this ensures that we are testing the code as it is compiled for release builds.)An advantage of this over using
--releasewhen running tests is that it builds with full debug information (as far as possible given that some things will be optimized out).