Skip to content

Migrate to zip32::hardened_only implementation #299

Migrate to zip32::hardened_only implementation

Migrate to zip32::hardened_only implementation #299

GitHub Actions / Clippy Result (stable) succeeded Oct 2, 2024 in 16s

Clippy (Stable ~ Linux/x86_64)

Clippy was successful!

Details

Running cargo clippy took roughly ~16427ms to complete

  • Working Directory: repository directory

Annotations

Check warning on line 534 in /home/runner/work/orchard/orchard/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Result (stable)

/home/runner/work/orchard/orchard/src/lib.rs#L534

usage of `Iterator::fold` on a type that implements `Try`
Raw output
warning: usage of `Iterator::fold` on a type that implements `Try`
   --> src/builder.rs:534:14
    |
534 |             .fold(Some(ValueSum::zero()), |acc, note_value| acc? + note_value)
    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(ValueSum::zero(), |acc, note_value| ...)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
    = note: `#[warn(clippy::manual_try_fold)]` on by default

Check warning on line 615 in /home/runner/work/orchard/orchard/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Result (stable)

/home/runner/work/orchard/orchard/src/lib.rs#L615

explicit call to `.into_iter()` in function argument accepting `IntoIterator`
Raw output
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
   --> src/builder.rs:615:18
    |
615 |             .zip(indexed_outputs.into_iter())
    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `indexed_outputs`
    |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
   --> /rustc/6a3b69c6b0529151da5fb4568961519a80adccf9/library/core/src/iter/traits/iterator.rs:598:12
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
    = note: `#[warn(clippy::useless_conversion)]` on by default

Check warning on line 19 in /home/runner/work/orchard/orchard/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Result (stable)

/home/runner/work/orchard/orchard/src/lib.rs#L19

doc list item without indentation
Raw output
warning: doc list item without indentation
  --> src/bundle/commitments.rs:19:5
   |
19 | ///   with ZCASH_ORCHARD_ACTIONS_COMPACT_HASH_PERSONALIZATION
   |     ^^
   |
   = help: if this is supposed to be its own paragraph, add a blank line
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
   = note: `#[warn(clippy::doc_lazy_continuation)]` on by default
help: indent this line
   |
19 | ///    with ZCASH_ORCHARD_ACTIONS_COMPACT_HASH_PERSONALIZATION
   |       +

Check warning on line 21 in /home/runner/work/orchard/orchard/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Result (stable)

/home/runner/work/orchard/orchard/src/lib.rs#L21

doc list item without indentation
Raw output
warning: doc list item without indentation
  --> src/bundle/commitments.rs:21:5
   |
21 | ///   with ZCASH_ORCHARD_ACTIONS_MEMOS_HASH_PERSONALIZATION
   |     ^^
   |
   = help: if this is supposed to be its own paragraph, add a blank line
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
   |
21 | ///    with ZCASH_ORCHARD_ACTIONS_MEMOS_HASH_PERSONALIZATION
   |       +

Check warning on line 23 in /home/runner/work/orchard/orchard/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Result (stable)

/home/runner/work/orchard/orchard/src/lib.rs#L23

doc list item without indentation
Raw output
warning: doc list item without indentation
  --> src/bundle/commitments.rs:23:5
   |
23 | ///   with ZCASH_ORCHARD_ACTIONS_NONCOMPACT_HASH_PERSONALIZATION
   |     ^^
   |
   = help: if this is supposed to be its own paragraph, add a blank line
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
   |
23 | ///    with ZCASH_ORCHARD_ACTIONS_NONCOMPACT_HASH_PERSONALIZATION
   |       +

Check warning on line 24 in /home/runner/work/orchard/orchard/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Result (stable)

/home/runner/work/orchard/orchard/src/lib.rs#L24

doc list item without indentation
Raw output
warning: doc list item without indentation
  --> src/bundle/commitments.rs:24:5
   |
24 | /// as defined in [ZIP-244: Transaction Identifier Non-Malleability][zip244]
   |     ^
   |
   = help: if this is supposed to be its own paragraph, add a blank line
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
   |
24 | ///    as defined in [ZIP-244: Transaction Identifier Non-Malleability][zip244]
   |     +++

Check warning on line 244 in /home/runner/work/orchard/orchard/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Result (stable)

/home/runner/work/orchard/orchard/src/lib.rs#L244

explicit call to `.into_iter()` in function argument accepting `IntoIterator`
Raw output
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
   --> src/note_encryption.rs:244:18
    |
244 |             .zip(ephemeral_keys.into_iter())
    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `ephemeral_keys`
    |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
   --> /rustc/6a3b69c6b0529151da5fb4568961519a80adccf9/library/core/src/iter/traits/iterator.rs:598:12
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

Check warning on line 195 in /home/runner/work/orchard/orchard/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Result (stable)

/home/runner/work/orchard/orchard/src/lib.rs#L195

usage of `Iterator::fold` on a type that implements `Try`
Raw output
warning: usage of `Iterator::fold` on a type that implements `Try`
   --> src/value.rs:195:14
    |
195 |         iter.fold(Ok(ValueSum(0)), |acc, v| (acc? + *v).ok_or(OverflowError))
    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(ValueSum(0), |acc, v| ...)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold

Check warning on line 201 in /home/runner/work/orchard/orchard/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Result (stable)

/home/runner/work/orchard/orchard/src/lib.rs#L201

usage of `Iterator::fold` on a type that implements `Try`
Raw output
warning: usage of `Iterator::fold` on a type that implements `Try`
   --> src/value.rs:201:14
    |
201 |         iter.fold(Ok(ValueSum(0)), |acc, v| (acc? + v).ok_or(OverflowError))
    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(ValueSum(0), |acc, v| ...)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold

Check warning on line 0 in ./file/that/probably/doesnt/exist.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Result (stable)

./file/that/probably/doesnt/exist.rs#L0

11 warnings emitted
Raw output
warning: 11 warnings emitted