improve explanation of synth function for deriving coeffs of lookup function #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ebfull would be nice if you could ack this. |
stefandeml
pushed a commit
to stefandeml/sapling-crypto
that referenced
this pull request
Jul 5, 2019
* Minimal zigzag circuit scaffolding. * Rename make_circuit to circuit, to emphasize that this is an inexpensive assembly. * --wip-- [skip ci] * DrgPoRep compiles (without tests). * DrgPoRep tests pass. * Don't pass Options to synthesize function. * Cleanup. * Extend Option de-conversion to examples. * DrgPoRepCompound inputize creates the right number of inputs. * DrgPoRep Circuit test_compound compiles. * Fix constraint-count test. * Repeat bad parents test if random data doesn't exercise it. * Include graph random seed in DrgParams (included in drgporep::SetupParams). * Split verify into verify_inputs and verify_proof. * Some drgporep circuit cleanup. * Use (vanilla) proof when verifying inputs. * Implement verify_inputs for merklepor. * Rename verify_inputs to verify_proof_meta. * Implement verify_prove_meta for drgporep. * CHECKPOINT WIP -- drgporep circuit test_compound passing. * WIP All code running, some constraints not satisfied. * Extract data from replicat for data node. Drgporep compound test passing. * Back out small changes to ease diff review. * Remove superfluous [feature]. * Directly verify that supplied challenge is the one proved. * Cleanup. * Remove defunct comment. * Reinstate Options everywhere. * Rustfmt and clippy. * Rebase fixes. * Bump cargo version to clear cache. * Different rustfmt. * Try rustfmt synced to newly-built docker image. * Bump prefix to clear cargo cache on CI. * Use Fr::rand(). * Add FIXME for BatchPoST verify_proof_meta. * Remove stray comment. * Typo. * Add documentation comment. * Comment. * Doc comment. * Remove verify_proof_meta. * Bump cargo cache key. * Rename inputize to generate_public_inputs and document traits. * Bump cargo cache key. (We need to fix this.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #75 that did more stuff and people had issues with.