Allow progress updates without images, for 2x and 4x upscales for exa… - #242
Open
owengo wants to merge 1 commit into
Open
Allow progress updates without images, for 2x and 4x upscales for exa…#242owengo wants to merge 1 commit into
owengo wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the new upscale x2 and x4, we receive progress updates but the attachments list is empty, so there is no image progress sent to the client. These upscales are very slow so it creates a long delay without any progress and can cause problems to client applications.
With this small patch, if the user configures UpdateProgressWithoutImage to "true", these updates will be sent with the "EmptyImageUri" from the config ( defaults to "about:blank" ).
By default behavior is the same as before.