feat: check for eza to use in $ZINIT[LIST_COMMAND] option
#636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladdoster
changed the title
eza for LIST_COMMAND optioneza to use in LIST_COMMAND option
vladdoster
changed the title
eza to use in LIST_COMMAND optioneza to use in $ZINIT[LIST_COMMAND] option
The `exa` project is unmaintained and development moved the `eza` fork, but as of 1707207983, `eza` does not release prebuilt macOS binaries unlike `exa`. To avoid unnecessarily breaking user configurations, `exa` has not been removed.
HeroCC
reviewed
May 17, 2024
Comment on lines
66
to
+69
| if (( ${+commands[exa]} )); then | ||
| ZINIT[LIST_COMMAND]='exa --color=always --tree --icons -L3' | ||
| elif (( ${+commands[eza]} )); then | ||
| ZINIT[LIST_COMMAND]='eza --color=always --tree --icons -L3' |
There was a problem hiding this comment.
Maybe check for eza before exa? If both are installed on the system, we'd probably want to prefer the non-deprecated one.
Suggested change
| if (( ${+commands[exa]} )); then | |
| ZINIT[LIST_COMMAND]='exa --color=always --tree --icons -L3' | |
| elif (( ${+commands[eza]} )); then | |
| ZINIT[LIST_COMMAND]='eza --color=always --tree --icons -L3' | |
| if (( ${+commands[eza]} )); then | |
| ZINIT[LIST_COMMAND]='eza --color=always --tree --icons -L3' | |
| elif (( ${+commands[exa]} )); then | |
| ZINIT[LIST_COMMAND]='exa --color=always --tree --icons -L3' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
exaproject is unmaintained and development moved theezafork, but as of 1707207983,ezadoes not release prebuilt macOS binaries unlikeexa. To avoid unnecessarily breaking user configurations,exahas not been removed.Types of changes
Checklist: