fix: do not apply resource till applyparams() calls

Signed-off-by: Wen Zhou <[email protected]>
zdtsw-forking · Sep 10, 2024 · 005b9d2 · 005b9d2
1 parent 8b63c37
commit 005b9d2
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/components/workbenches/workbenches.go b/components/workbenches/workbenches.go
@@ -131,10 +131,6 @@ func (w *Workbenches) ReconcileComponent(ctx context.Context, cli client.Client,
 			return err
 		}
 	}
-	if err := deploy.DeployManifestsFromPath(ctx, cli, owner, notebookControllerPath, dscispec.ApplicationsNamespace, ComponentName, enabled); err != nil {
-		return fmt.Errorf("failed to apply manifetss %s: %w", notebookControllerPath, err)
-	}
-	l.WithValues("Path", notebookControllerPath).Info("apply manifests done NBC")
 
 	// Update image parameters for nbc
 	if enabled {
@@ -149,6 +145,11 @@ func (w *Workbenches) ReconcileComponent(ctx context.Context, cli client.Client,
 			}
 		}
 	}
+	if err := deploy.DeployManifestsFromPath(ctx, cli, owner, notebookControllerPath, dscispec.ApplicationsNamespace, ComponentName, enabled); err != nil {
+		return fmt.Errorf("failed to apply manifetss %s: %w", notebookControllerPath, err)
+	}
+	l.WithValues("Path", notebookControllerPath).Info("apply manifests done NBC")
+
 	if err := deploy.DeployManifestsFromPath(ctx, cli, owner,
 		kfnotebookControllerPath,
 		dscispec.ApplicationsNamespace,