fix: asset download handeling and binary path #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update the extension to use the new download path structure which is now `"{version_dir}/{binary}"` instead of `"{version_dir}/{asset_without_ext}/{binary}"`.
- Update the MacOS asset download by updating from a `tar.gz` archive to the `.zip` archive that is now being used by SuperHTML.
All the assets that use an `xz` extension are not currently supported in the Zed extension API. The reason the team does not support xz downloads is because of the xz takeover that happened.
Collaborator
|
Yeah, I know about the xz thing and I think it's just dumb tbh. Can we maybe do this by manually calling |
Author
|
I’m sure we can find a solution similar to that, but I’m not familiar with the extent of control extension developers have. Here are some potential options to address this issue:
Aside from that, I’m not entirely sure what we could do. I’ll investigate other extensions to see if they use the same Uncompressed download type, as I’m quite certain the Java extension does. It appears that the SuperHTML dev is aware of the changes breaking many tools that relied on the specific release style. Homebrew/homebrew-core#245261 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"{version_dir}/{binary}"instead of"{version_dir}/{asset_without_ext}/{binary}".tar.gzarchive to the.ziparchive that is now being used by SuperHTML.Additional Notes: All the assets that use an
xzextension are not currently supported in the Zed extension API. The reason the team does not support xz downloads is because of the xz takeover that happened.Partially addresses #4