Preserve configured model options missing from preset catalog#237
Open
garrza wants to merge 1 commit into
Open
Preserve configured model options missing from preset catalog#237garrza wants to merge 1 commit into
garrza wants to merge 1 commit into
Conversation
Author
|
TLDR The bug was this:
The PR adds a small session memory: It is seeded from the configured model when the thread starts. So if the thread starts with gpt-5.5, ACP remembers that raw model ID. The core fix is the picker logic so Codex ACP does not lose a valid configured model just because that model is missing from the current UI preset catalog. The bug happened when source 1 had gpt-5.5, but source 2 did not. Important guardrail: if a model does exist in the preset catalog but has show_in_picker = false, we still hide it after switching away. So the PR does not bypass intentional hidden model behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #236
Testing
cargo testcargo clippy --all-targets -- -D warnings