Add timeout overrides for MCP server configuration#278
Open
BitsInBytes wants to merge 2 commits into
Open
Conversation
Fixes for issue 227 (zed-industries#277) When mcpServers are provided dynamically via ACP session/new or session/load, codex-acp rebuilds each server config and hard-sets: startup_timeout_sec = None tool_timeout_sec = None This makes timeout tuning impossible for dynamically injected MCP servers, even though static TOML-configured servers support these fields. This change now allows MCP meta data to be included to configure the MCP timeouts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes for issue 227 (#277)
When mcpServers are provided dynamically via ACP session/new or session/load, codex-acp rebuilds each server config and hard-sets:
startup_timeout_sec = None
tool_timeout_sec = None
This makes timeout tuning impossible for dynamically injected MCP servers, even though static TOML-configured servers support these fields.
This change now allows MCP meta data to be included to configure the MCP timeouts.