Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux: Better handle activation of opened URLs and directories #13336

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

apricotbucket28
Copy link
Contributor

Fixes browser windows not being activated on KDE/Wayland after some recent system update

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jun 20, 2024
@mikayla-maki
Copy link
Contributor

I don't have a good intuition for the availability of desktop portals. Could we switch Zed to only use the desktop portal implementation? Or is open useful as a fallback?

@apricotbucket28
Copy link
Contributor Author

I don't have a good intuition for the availability of desktop portals. Could we switch Zed to only use the desktop portal implementation? Or is open useful as a fallback?

I left it because it's a simple fallback and to prevent cases like "Zed cannot open urls". However, we already heavily rely on portals elsewhere so maybe we could just drop open entirely (in that case I'll also need to switch the reveal_path function to use ashpd, which should be trivial).

@mikayla-maki
Copy link
Contributor

I think I'd prefer that solution for overall code simplicity. If we have to patch around missing portals, I'd rather we had some data on whether it's working for people.

Thank you for this change!

@apricotbucket28 apricotbucket28 changed the title linux: Open urls using desktop portal first linux: Better handle activation of opened urls and directories Jun 20, 2024
@maxdeviant maxdeviant changed the title linux: Better handle activation of opened urls and directories linux: Better handle activation of opened URLs and directories Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants