-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
csharp: Solve problem of omnisharp server failing to download #13367
base: main
Are you sure you want to change the base?
Conversation
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: 杨小龙.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it’s touching non-zip code paths.
The tar and tar.gz paths should be left as-is.
8206618
to
3c12f67
Compare
We require contributors to sign our Contributor License Agreement, and we don't have @windoflake on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
The cla-bot has been summoned, and re-checked this pull request! |
3c12f67
to
f6b1ee5
Compare
Use async_zip to extract the downloaded language zip file instead of calling 'unzip' command. Fixes zed-industries#9181
f6b1ee5
to
32266d0
Compare
@maxdeviant , That's right. I've updated the code accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I seem to overwrite my last push by a forcing push.
This is actually the commit that I changed according to the review comments. @maxdeviant
Fix issue #9181: #9181.
unzip
, zed should be working fine with it.Release Notes: