Skip to content

fs: Return trashed file location #52012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dinocosta merged 15 commits into from
Apr 9, 2026
+308 −155
Merged

fs: Return trashed file location #52012

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
e58f34e
chore(fs): add trash dependency
dinocosta Mar 1, 2026
e513dea
Merge branch 'main' into 5039-fs-update
dinocosta Mar 1, 2026
fdbd61d
fix: explicit type annotation and unsafe block removal
dinocosta Mar 1, 2026
9c0411d
refactor(fs): replace platform-specific trash implementations
dinocosta Mar 1, 2026
5661584
refactor(fs): replace platform-specific trash_dir implementations
dinocosta Mar 2, 2026
fac34ca
feat(fs): keep track of trashed files and directories
dinocosta Mar 2, 2026
311417e
chore: remove duplicate removed event emission
dinocosta Mar 3, 2026
f0bafd5
Merge branch 'main' into 5039-fs-update
dinocosta Mar 20, 2026
2a94100
fix(fs): fix missing test attribute
dinocosta Mar 20, 2026
b414892
fix(fs): fix import name conflict on linux
dinocosta Mar 20, 2026
ebfb355
docs: improve trashed entry documentation
dinocosta Mar 25, 2026
bbe30a4
refactor(fs): remove unused dependencies
dinocosta Mar 25, 2026
794b4e7
refactor(fs): remove unused options argument
dinocosta Mar 26, 2026
500e08c
chore: update trash dependency
dinocosta Apr 8, 2026
4f29a26
Merge branch 'main' into 5039-fs-update
dinocosta Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 63 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions crates/fs/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ time.workspace = true
util.workspace = true
is_executable = "1.0.5"
notify = "8.2.0"
trash = { git = "https://github.com/dinocosta/trash-rs", branch = "5039-macos-restore" }
Comment thread
dinocosta marked this conversation as resolved.
Outdated

[target.'cfg(target_os = "macos")'.dependencies]
objc.workspace = true
Expand Down
Loading
Loading