ZeekPluginDynamic: Handle DIST_FILES in CMake #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bbannier - this is what maybe could work for zeek/package-template#37 (review) in the future. Is this more in the direction you were thinking of? |
bbannier
reviewed
Jun 27, 2024
awelzel
force-pushed
the
topic/awelzel/dynamic-plugin-dist-files
branch
2 times, most recently
from
ab54fa5
to
57b0d06
Compare
Move path wrangling of DIST files from zeek-plugin-create-package.sh into CMake logic. New logic: Location of files in dist is based relative to the PROJECT_SOURCE_DIR. This removes the assumption of having build/ located within the source directory (and zeek-plugin-create-package.sh running from build/).
awelzel
force-pushed
the
topic/awelzel/dynamic-plugin-dist-files
branch
from
57b0d06
to
c5eac15
Compare
Grumble - this subtly changes how we deal with symlinks: Having |
There's a pattern of README -> README.md symlinking. Using README as dist file should not package the README.md file.
awelzel
force-pushed
the
topic/awelzel/dynamic-plugin-dist-files
branch
from
2e20322
to
cc9de7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move path wrangling of DIST files from zeek-plugin-create-package.sh into CMake logic.
New logic: Relative paths have all leading ../ components strip to determine the location within the resulting tarball. This also removes the assumption of having build/ located within the source directory (and zeek-plugin-create-package.sh running from build/).
The quirky part is that the script deletes the produced files after creating the tarball.