Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add plugin/CMakeLists.txt #37

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add plugin/CMakeLists.txt #37

wants to merge 1 commit into from

Commits on Jun 26, 2024

  1. Add plugin/CMakeLists.txt 

    Support for BRO_PLUGIN_BASE has been removed, resulting in the
ZeekPluginDynamic.cmake code to pick-up ${CMAKE_CURRENT_SOURCE_DIR}/scripts
as the plugin's script. For the package-template's generated skeleton,
these are however the extra scripts usually installed via zkg.

Propose creation of another CMakeLists.txt within plugin/ to prevent
this.

The main wart here is that zeek-plugin-create-package.sh contains assumption
about the location of additional DIST_FILES (../ relative to the build directory),
so we copy these at configure time into build/ to fix this.

I'm liking this more than re-introducing support for BRO_PLUGIN_BASE,
but not sure it's overly great.

Closes #35
    @awelzel
    awelzel committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    e3116a7 View commit details
    Browse the repository at this point in the history