Fix computation of message length #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of zeek/zeek@fe8390c `dns_msg` also contains `AD` and `CD` bits which changes the baseline. Instead of adding test logic for unsupported Zeek versions only run this test for newer versions.
bbannier
force-pushed
the
topic/bbannier/issue-10
branch
from
b6006b7
to
c088941
Compare
rsmmr
reviewed
Sep 14, 2023
`ResourceRecord.rdlen` is the length of the payload in `bytes`, but we used it as the number of entries for `TXT` records. With this patch we compute the correct length by setting up a view of the correct size; this also fix issues with different record types where they would not consume not the correct amount of input. Closes #10. Closes #11.
bbannier
force-pushed
the
topic/bbannier/issue-10
branch
from
c088941
to
493b266
Compare
rsmmr
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10.
Closes #11.