scene_table.h tweak

[mzxrules]

Contributions made in this pr are licensed under CC0

This pr makes it so that the SceneID enumeration now stores the values for scenes that are missing in some versions.

[Dragorn421]

I prefer the current way the deleted scenes' enum values are handled

[mzxrules]

inconsistent and unshifting?

[Dragorn421]

The current way is simpler, not having to mess with the scene table .h
The values don't need to shift for any purpose (this was discussed back then), but if you really wanted to it'd be simpler to just adjust the definition of the additional debug SCENE_ macros

[mzxrules]

i don't understand.

• If you add scenes you have to touch scene_table.h
• If you subtract scenes you have to touch scene_table.h
• If you reorder scenes you have to touch scene_table.h

The difference now is that if you want to use a debug scene like the test map in a non debug setting, you no longer have to update z64save.

[Thar0]

This #if logic makes the table unnecessarily hard to read, I'd prefer if we just had DEFINE_SCENE_DEBUG and DEFINE_SCENE_DELETED and defined them at all include sites to keep the table itself easier to read

[mzxrules]

I don't know how you would implement DEFINE_SCENE_DEBUG in a sane way. The debug scenes are not dummied into the scene table in release builds, so a custom mod that mixed DEFINE_SCENE and DEFINE_SCENE_DEBUG declarations could desync the enumeration.