Skip to content

Conversation

@Dragorn421
Copy link
Collaborator

Followup to #2640

I expect this to be less consensual and am open to suggestions or even just closing if no consensus can be reached.

@mzxrules
Copy link
Contributor

PlayerKnockType isn't quite right, but I don't have anything immediately popping off the top of my head that makes sense. Like to me this is how it should be, I just don't know what word fits the ? slot.

typedef enum Player?Type {
    /* 0 */ PLAYER_?_NONE, // No ?
    /* 1 */ PLAYER_?_KNOCKBACK, // A small hop, remains standing up
    /* 2 */ PLAYER_?_KNOCKDOWN, // Sent flying in the air and lands laying down on the floor
    /* 3 */ PLAYER_?_KNOCKDOWN_ELECTRIFIED // Same as `PLAYER_?_KNOCKDOWN` with a shock effect
} Player?Type;

And just a pin for later, don't forget to update the function names in z_actor.c and the player->knockback* variables if/when you have a better idea on how to move forward with this.

@Dragorn421
Copy link
Collaborator Author

Updated to PLAYER_BUMP_KNOCKBACK, PLAYER_BUMP_KNOCKDOWN, Actor_SetPlayerBump*, Player.bump*

@Dragorn421 Dragorn421 added One approval Has one approval, can be merged in 48 hours if nothing else comes up Needs discussion There is a debate or other required discussion preventing changes from being made labels Jul 1, 2025
@Dragorn421
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs discussion There is a debate or other required discussion preventing changes from being made One approval Has one approval, can be merged in 48 hours if nothing else comes up

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants