Document N64DD data buffer #2665
Open
+8
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cadmic
approved these changes
Nov 1, 2025
AngheloAlf
approved these changes
Nov 2, 2025
|
Merging tomorrow to give room for any more possible feedback |
Thar0
reviewed
Nov 2, 2025
src/n64dd/n64dd_data_buffer.c
Outdated
Comment on lines
3
to
5
| // Buffer used during the process of reading from the disk | ||
| // Used to directly read individual LBAs/blocks from the disk before copying to the final destination | ||
| // As blocks/LBAs are read directly into this buffer from the disk, it has to be 16-byte aligned |
There was a problem hiding this comment.
There's no need to write "block/LBA", Logical Block Addresses are more like pointers to data than the data itself, so you can just write "block" or "logical block" for this.
On alignment, 16 bytes is a recommended alignment to prevent data cache alignment but for DMA the minimum sane RAM alignment is 8 bytes, so I believe "should be" is slightly more appropriate than "has to be" in this case.
Suggested change
| // Buffer used during the process of reading from the disk | |
| // Used to directly read individual LBAs/blocks from the disk before copying to the final destination | |
| // As blocks/LBAs are read directly into this buffer from the disk, it has to be 16-byte aligned | |
| // Buffer used during the process of reading from the disk. | |
| // Used to directly read individual blocks from the disk before copying to the final destination. | |
| // As blocks are read directly into this buffer from the disk, it should be 16-byte aligned. |
There was a problem hiding this comment.
I've adjusted the commit accordingly
GabrielRavier
force-pushed
the
feat/document-src-n64dd-data-buffer
branch
from
a029dc6 to
4a15a93
Compare
Thar0
approved these changes
Nov 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.