Merged
Conversation
Contributor
|
@hatal175 , if you tried marking the TU as Matching, would it go through? |
Contributor
Author
|
It didn't. I think it had extra data in the .data section. |
Contributor
Author
|
I've no idea what segfaulted in the github build |
Report for GZ2E01 (46a11f2 - 43f0385)📈 Matched code: 79.62% (+0.06%, +6852 bytes) ✅ 34 new matches
...and 4 more new matches |
Contributor
|
is the pch data actually being linked? cause objdiff is just going to show it for any TU that includes it now, making it a bit annoying to diff, but it shouldnt actually effect anything when trying to build due to it being stripped |
Contributor
Author
|
Maybe not. Still have no idea why it doesn't match.
…On Mon, Aug 25, 2025, 02:14 TakaRikka ***@***.***> wrote:
*TakaRikka* left a comment (zeldaret/tp#2602)
<#2602 (comment)>
is the pch data actually being linked? cause objdiff is just going to show
it for any TU that includes it now, making it a bit annoying to diff, but
it shouldnt actually effect anything when trying to build due to it being
stripped
—
Reply to this email directly, view it on GitHub
<#2602 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACYQXXJ36UDPENWZKDNWTOT3PJBL7AVCNFSM6AAAAACEWA6SKKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTEMJYGQ2DCNZUGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Contributor
|
@hatal175 , in |
Contributor
Author
|
Good catch. Kinda hard to work on data after pch change in objdiff. |
Contributor
|
I pulled @LagoLunatic 's changes for objdiff locally, rebuilt objdiff, and I was able to view the diff easily. |
TakaRikka
approved these changes
Aug 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.