-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 3D and map plotting tools #800
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting functionality. Just some initial thoughts.
}; | ||
}, | ||
{}, | ||
[DIK_R, [false, false, false]] // Default: R |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These keybinds conflict with the same base game Zeus controls. I think a default behind some modifiers since this doesn't need to be so accessible would be good.
class Meter { | ||
formatter = QUOTE(format [ARR_2('%1 m',_value toFixed 1)]); | ||
priority = 100; | ||
}; | ||
class Feet { | ||
formatter = QUOTE(format [ARR_2('%1 ft',(_value * 3.281) toFixed 1)]); | ||
priority = 90; | ||
}; | ||
class Yards { | ||
formatter = QUOTE(format [ARR_2('%1 yd',(_value * 1.094) toFixed 1)]); | ||
priority = 80; | ||
}; | ||
class Mile { | ||
formatter = QUOTE(format [ARR_2('%1 mi',(_value / 1609.344) toFixed 2)]); | ||
priority = 70; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these could be made more complex. For example, I don't think the decimal point is needed after 100 m and for any moving object it just flickers. Essentially, increase precision for small values, decrease for large ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea
|
||
private _formatterString = getText (_entryConfig >> "formatter"); | ||
if (_formatterString isNotEqualTo "") then { | ||
_formatterString = "params ['_value']; " + _formatterString; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary, just pass the value in _this
and then, format ["%1 m", _this]
for example.
Thanks for the initial feedback! Can you maybe provide feedback on following question too?
|
|
private _azimuthToStart = _endPos getDir _startPos; | ||
private _azimuthToEnd = _startPos getDir _endPos; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be the relative direction?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the direction from start to end pos and end to start. Both _startPos
and _endPos
are PosASL. I don't understand the relative part in your question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC, when attached to objects the direction value being displayed did not seem intuitive. If that makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to check what you mean. It should show the same value as the unit just opening their compass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it just comes to whether we want to know that the position is 90 degrees relative to the vehicle or just the difference in their bearings. The former what what I assumed the value was.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What purpose does relative bearing w.r.t. the attached unit have to the Zeus or any unit on the ground? I understand if you want the direction as a relative clock, but I have never given or received relative bearing. For artillery corrections, you also don't use relative directions.
When merged this pull request will:
This feature is meant to help the user measure distances and directions. The start and end positions can be either static or attached to an object, where the values are then updated dynamically. The user can toggle between different distance and azimuth formats using R and Tab ↹. More formatters can be defined in
class zen_plotting_formatters
. The color can be changed in the CBA settings. Plotting is possible in 3D or on the map.TODO
Optimize drawing (do not draw if outside screen)The overhead of checking if the positions are in view is too high ~2x perf decrease