Remove call to on_shard directly on ActiveRecord::Base #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobat
approved these changes
Dec 11, 2017
Contributor
|
I agree, tests would be great. How do we test rake tasks? |
Contributor
|
require the file and then .execute the task
alternatively extract logic into static methods
…On Mon, Dec 11, 2017 at 1:47 PM, Jacob Atzen ***@***.***> wrote:
I agree, tests would be great. How do we test rake tasks?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#167 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAsZwvjcXM8m9gwWZowSe68HxqeR3mZks5s_aMPgaJpZM4Q-DLu>
.
|
Contributor
Author
|
What I tend to do is write what I need in |
Contributor
Author
|
It's more complicated than anticipated since |
Contributor
💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this call was missed when moving the
on_shardmethod out of AR::Base and making the default not_sharded./cc @bquorning @grosser @jacobat