Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display translated error messages for service submission #579

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

Fredx87
Copy link
Contributor

@Fredx87 Fredx87 commented Feb 11, 2025

Description

This PR fixes the display of error messages on the Service item page. We were passing the locale parameter in the body instead of as a query parameter, so the messages were not translated

Screenshots

Before:

Screenshot 2025-02-11 at 17 41 56

After:

Screenshot 2025-02-11 at 17 41 23

Checklist

  • 📗 all commit messages follow the conventional commits standard
  • ⬅️ changes are compatible with RTL direction
  • ♿ Changes to the UI are tested for accessibility and compliant with WCAG 2.1.
  • 📝 changes are tested in Chrome, Firefox, Safari and Edge
  • 📱 changes are responsive and tested in mobile
  • 👍 PR is approved by @zendesk/vikings

@Fredx87 Fredx87 requested a review from a team as a code owner February 11, 2025 16:46
@Fredx87 Fredx87 merged commit 4a654a0 into beta Feb 12, 2025
5 checks passed
@Fredx87 Fredx87 deleted the gianluca/fix-request-locale branch February 12, 2025 12:19
@zd-svc-github-copenhagen-theme
Copy link
Collaborator

🎉 This PR is included in version 4.3.0-beta.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants