This repository was archived by the owner on Nov 23, 2024. It is now read-only.
OAuth2 Auth Flow #67
Open
OAuth2 Auth Flow #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a the `auth_type` configuration setting, defaults to "oauth"
Data should be passed as parameters in the body of the request instead of converting it into query string params. Query string will work for smaller amounts of data, but errors arise when the query string becomes too long. For example this is often the case when requesting deltas using a long cursor string.
…th2-support Conflicts: dropbox-api.gemspec
Some notes: - I had to modify the logic in one Dropbox::API::Client#delta test because in my tests the last item returned by the delta API was actually the `test_dir` itself, not the file within it. I made the test flexible enough to handle either case: "file last" or "dir last". - Added a `type` key to connection.yml to indicate that the token provided is either "oauth2" or "oauth1". When ommitted, "oauth1" is assumed. - Alternatively ENV['AUTH']=oauth2 can be set when running the tests. This will override whatever is specified in connection.yml - I think ideally the spec would run all of the tests twice: once with an OAuth1 token and once with OAuth2, but that's a bit more than I have time for.
…box during token exchange
|
Can it be merged? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick-and-dirty flow dependent on #62, I'll update the Readme and finalize the patch once #62 is in. Will rebase on demand.
The auth would be simplified to be:
And done.