This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Update directory structure #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forward port zendframework#23
Forward port zendframework#24
Forward port zendframework#30
Forward port zendframework#32
Forward port zendframework#35
Per zendframework/zend-expressive#176 (comment), this patch does the following: - Creates a `src/App/` subdirectory, and moves `src/Action/` and `src/Composer` beneath them. - Creates a `test/AppTest/` subdirectory, and moves `test/Action/` beneath it. - Updates the `autoload` and `autoload-dev` entries for `App` and `AppTest`, respectively, to reference the new paths. - Updates the `App\Composer\OptionalPackages` class to reference `src/App/Action` instead of `src/Action/` when specifying the directory to remove during a minimal installation. It also ensures that the default tests are removed during minimal installation (which wasn't handled previously, and spotted when making the directory changes).
|
Closing; branched from develop instead of master. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per zendframework/zend-expressive#176#issuecomment-160106303, this patch does the following:
src/App/subdirectory, and movessrc/Action/andsrc/Composerbeneath them.test/AppTest/subdirectory, and movestest/Action/beneath it.autoloadandautoload-deventries forAppandAppTest, respectively, to reference the new paths.App\Composer\OptionalPackagesclass to referencesrc/App/Actioninstead ofsrc/Action/when specifying the directory to remove during a minimal installation. It also ensures that the default tests are removed during minimal installation (which wasn't handled previously, and spotted when making the directory changes).I'll be creating a corresponding update to the documentation, which I will link to this issue.