Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added duck #410

Merged
merged 4 commits into from
Oct 24, 2024
Merged

added duck #410

merged 4 commits into from
Oct 24, 2024

Conversation

sohailshk
Copy link
Contributor

Description

Here my contribution to "The Duck Gallery".

You must respect the following conditions

  1. Your contribution must respect the code of conduct
  2. It's your first PR to this repository
  3. You have added your image of the duck downloaded from https://pimpmyduck.zenika.com
  4. You have not changed the image of the duck
  5. The image filename must be your GitHub username (ex: your-username.png)
  6. You are using your own GitHub user and it's the same as the PR author
  7. Into the contributors.js file, the message must be short and respect the code of conduct

If the PR doesn't respect those conditions, it will be closed

Copy link
Member

@jeanphi-baconnais jeanphi-baconnais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Happy Hacktoberfest

@sohailshk
Copy link
Contributor Author

I have updated contributors.js and resolved the conflict please consider my pr and please add hacktoberfest and hacktoberfest-accepted label

contributors.js Outdated Show resolved Hide resolved
Co-authored-by: Jean-Phi Baconnais <[email protected]>
Copy link
Member

@jeanphi-baconnais jeanphi-baconnais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sohailshk , you know, this project has Hacktoberfest label, so no worry, your PR count for this challenge without tagging this PR as hacktoberfest or hacktoberfest-accepted :)

@jeanphi-baconnais jeanphi-baconnais merged commit 7d63050 into zenika-open-source:main Oct 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants