Release #717
Release #717
Conversation
* fix: add missing "copy" button to stack's name * fix: open "set this stack" by default * fix: link to "artifact store" stack component from artifact overview
WalkthroughThis pull request encompasses several modifications across different components in the ZenML web application. The changes primarily focus on text corrections, UI enhancements, and data structure improvements. Key updates include adding copy buttons to stack columns, introducing an AWS Image Builder component, modifying search field styling, and enhancing artifact node representations with type information. Changes
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (5)
src/app/stacks/columns.tsx (1)
Line range hint
31-36: Consider adding aria-labels for better accessibility.The copy buttons enhance usability. Consider adding descriptive aria-labels to improve accessibility.
-<CopyButton copyText={name}></CopyButton> +<CopyButton copyText={name} aria-label={`Copy stack name: ${name}`} /> -<CopyButton copyText={id} /> +<CopyButton copyText={id} aria-label={`Copy stack ID: ${id}`} />src/components/SearchField.tsx (1)
68-81: Consider enhancing keyboard accessibility.The search icon integration looks good, but consider adding aria-label to improve accessibility for screen readers.
<div className="relative"> <Input className="pl-[36px]" + aria-label="Search input field" {...rest} ref={ref} value={searchQuery} onChange={searchHandler} placeholder="Search..." inputSize="md" /> <div className="absolute inset-y-0 left-0 flex items-center pl-1"> - <Search className="size-4 fill-neutral-400" /> + <Search className="size-4 fill-neutral-400" aria-hidden="true" /> </div> </div>src/components/dag-visualizer/layout/real-data.ts (1)
39-39: Consider using a type constant for better maintainability.The artifactType implementation is consistent. Consider defining a constant for the artifact types to maintain consistency and type safety across the codebase.
// Add to types/pipeline-runs.ts export const ARTIFACT_TYPES = { INPUT: 'input', OUTPUT: 'output' } as const; export type ArtifactType = typeof ARTIFACT_TYPES[keyof typeof ARTIFACT_TYPES]; // Then update the usage: data: { ...version, name: outputName, artifactType: ARTIFACT_TYPES.OUTPUT } data: { ...artifactVersion, name: inputName, artifactType: ARTIFACT_TYPES.INPUT }Also applies to: 52-52
src/components/dag-visualizer/layout/helper.ts (1)
71-82: Consider a more functional approach for handling duplicates.While the logic is correct, consider using a more functional and immutable approach instead of mutating the array with
splice.Here's a suggested refactoring that maintains immutability:
- if (realArtifact.data.artifactType === "output") { - for (const node of duplicateRealArtifacts) { - // remove node from finalNodes based on id - const index = finalNodes.findIndex((finalNode) => finalNode.id === node.id); - if (index !== -1) { - finalNodes.splice(index, 1); - } - } - - finalNodes.push(realArtifact); - } + if (realArtifact.data.artifactType === "output") { + const filteredNodes = finalNodes.filter(node => !duplicateRealArtifacts.some(dup => dup.id === node.id)); + finalNodes = [...filteredNodes, realArtifact]; + }src/components/artifacts/artifact-node-sheet/DetailCards.tsx (1)
186-186: Consider handling invalid routes more gracefully.The empty string fallback for undefined
artifactStoreIdcould lead to invalid routes. Also, the explicit type annotation is redundant as TypeScript can infer it.-const artifactStoreHref: string = routes.components.detail(artifactStoreId || ""); +const artifactStoreHref = artifactStoreId ? routes.components.detail(artifactStoreId) : "#";
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (10)
src/app/onboarding/Setup/Items.tsx(2 hunks)src/app/settings/service-accounts/[service-account-id]/Success.tsx(2 hunks)src/app/stacks/columns.tsx(1 hunks)src/app/stacks/create/new-infrastructure/Providers/AWS.tsx(1 hunks)src/components/SearchField.tsx(3 hunks)src/components/artifacts/artifact-node-sheet/DetailCards.tsx(2 hunks)src/components/dag-visualizer/layout/helper.ts(1 hunks)src/components/dag-visualizer/layout/real-data.ts(2 hunks)src/components/stacks/Sheet/index.tsx(1 hunks)src/types/pipeline-runs.ts(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- src/app/settings/service-accounts/[service-account-id]/Success.tsx
🔇 Additional comments (5)
src/types/pipeline-runs.ts (1)
14-14: LGTM! Well-structured type definition.The addition of
artifactTypewith string literal type"input" | "output"provides clear type safety for artifact classification.src/components/SearchField.tsx (1)
40-43: Simplified conditional check looks good.The simplified check for
inMemoryHandleris cleaner and maintains the same functionality.src/app/stacks/create/new-infrastructure/Providers/AWS.tsx (1)
92-104: LGTM! Well-structured AWS Image Builder component.The new AWS Image Builder component follows the established pattern and maintains consistency with other components in the file.
src/app/onboarding/Setup/Items.tsx (1)
21-21: LGTM! Improved text consistency.Good improvement in grammar and consistency by changing "Login" to "Log in" when used as a verb.
Also applies to: 31-31
src/components/stacks/Sheet/index.tsx (1)
167-167: LGTM! Better UX with initially open card.Good improvement to show the stack setup instructions immediately by setting
initialOpenon the CollapsibleCard.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Summary by CodeRabbit
Release Notes
New Features
Improvements
UI/UX Changes