Fix markdown link checker for external PRs (#3333)

* Fix markdown link checker for external PRs

* Rename file

.github/workflows/check-markdown-links.yml

@@ -15,6 +15,6 @@ jobs:
       - name: Install dependencies
         run: pip install PyGithub
       - name: Run markdown link checker
-        run: ./scripts/check_and_comment.sh docs
+        run: ./scripts/check_broken_links.sh docs
         env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          GITHUB_TOKEN: ${{ github.event.pull_request.head.repo.fork == false && secrets.GITHUB_TOKEN ||  '' }}

scripts/check_and_comment.py → scripts/check_broken_links.py

@@ -146,15 +146,10 @@ def main():
     broken_links = check_markdown_links(directory)
 
     # If running in GitHub Actions, handle PR comment
-    if "GITHUB_TOKEN" in os.environ:
+    if token := os.environ.get("GITHUB_TOKEN"):
         # Only import github when needed
         from github import Github
 
-        token = os.environ.get("GITHUB_TOKEN")
-        if not token:
-            print("Error: GITHUB_TOKEN not set")
-            sys.exit(1)
-
         with open(os.environ["GITHUB_EVENT_PATH"]) as f:
             event = json.load(f)
 
@@ -181,7 +176,7 @@ def main():
         if existing_comment:
             existing_comment.edit(comment_body)
             print("Updated existing broken links report comment")
-        else:
+        elif broken_links:
             pr.create_issue_comment(comment_body)
             print("Created new broken links report comment")
 

scripts/check_and_comment.sh → scripts/check_broken_links.sh

@@ -20,10 +20,5 @@ if [ ! -d "$CHECK_DIR" ]; then
     exit 1
 fi
 
-# Only install PyGithub if we're running in GitHub Actions
-if [ -n "$GITHUB_TOKEN" ]; then
-    pip install PyGithub
-fi
-
 # Run the Python script
-python "$SCRIPT_DIR/check_and_comment.py" "$CHECK_DIR" 
+python "$SCRIPT_DIR/check_broken_links.py" "$CHECK_DIR"