-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow non ASCII in JSON dump with env var #3257
base: develop
Are you sure you want to change the base?
Allow non ASCII in JSON dump with env var #3257
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
…scii-chars-builtin-materializer' into feature/allow-non-ascii-chars-builtin-materializer
@@ -174,6 +174,11 @@ def handle_int_env_var(var: str, default: int = 0) -> int: | |||
"ZENML_PIPELINE_API_TOKEN_EXPIRATION" | |||
) | |||
|
|||
# Materializers environment variables | |||
ENV_ZENML_MATERIALIAZERS_ALLOW_NON_ASCII_JSON_DUMPS = ( | |||
"ZENML_MATERIALIAZERS_ALLOW_NON_ASCII_JSON_DUMPS" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a typo, it should be materializer
. Also, I would opt to keep them singular, e.g. ZENML_MATERIALIZER_ALLOW_NON_ASCII_JSON_DUMPS
Describe changes
Implementation for allowing non ASCII characters in JSON dumps. This has been done to have human readable output for languages with many non ASCII characters (such as any non english language :P)
Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes