-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the onboarding state to account for zenml login #3270
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
src/zenml/zen_server/auth.py
Outdated
# between web clients (i.e. the dashboard) and CLI clients (i.e. the | ||
# zenml CLI). | ||
user_agent = request.headers.get("User-Agent", "").lower() | ||
logger.info(f"User agent: {user_agent}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be a debug log instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was merely a left-over debug log. Removed now.
LLM Finetuning template updates in |
Classification template updates in |
E2E template updates in |
Describe changes
We used to rely on the "authorized device created" event to mark the "zenml connect" step in the onboarding state.
With "zenml login" taking the place of "zenml connect" and the new login experience, this is still valid for OSS servers, but the ZenML Pro servers no longer use "authorized devices" at the zenml server level, they use "authorized devices" at the ZenML Pro control plane level.
This PR fixes this by introducing:
User-Agent
header value set for all the API requests made by the ZenML Python client (to be able to differentiate ZenML client calls from other type of calls)Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes