Skip to content

Conversation

@harsha08-2k6
Copy link

I have read the CONTRIBUTING.md document.

I have added tests to cover my changes.

I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.

IMPORTANT: I made sure that my changes are reflected properly in the following resources:

ZenML Docs

Dashboard: Needs to be communicated to the frontend team.

Features: Might need adjustments (that are not reflected in the template tests) in case of non-breaking changes and deprecations.

Projects: Depending on the version dependencies, different projects might get affected.

Types of changes

Bug fix (non-breaking change which fixes an issue)

@bcdurak
Copy link
Contributor

bcdurak commented Nov 13, 2025

Hey @harsha08-2k6, thank you for your contribution. We'll take a look as soon as we can. In the meanwhile, could you change the target branch to develop instead of main?

@harsha08-2k6
Copy link
Author

Hey @bcdurak , i have changed the branch. Check and merge it to the repository.

@bcdurak
Copy link
Contributor

bcdurak commented Nov 14, 2025

Hey @harsha08-2k6, It is still targeted towards zenml-io:main.

@harsha08-2k6 harsha08-2k6 changed the base branch from main to develop November 15, 2025 05:29
@harsha08-2k6
Copy link
Author

Hey @bcdurak, thanks for the update! The target branch has now been changed correctly to develop. Please check and confirm.

@harsha08-2k6
Copy link
Author

Hey @bcdurak , i changed it from main to develop. kindly check and merge the pull request.

@bcdurak bcdurak self-requested a review November 20, 2025 13:40
@bcdurak
Copy link
Contributor

bcdurak commented Nov 20, 2025

Hey @harsha08-2k6, it seems like you have opened two PRs that address the same issue (this one and this one) and they are slightly different. Could you point us to which one we should take a look at and close the other one?

@harsha08-2k6
Copy link
Author

harsha08-2k6 commented Nov 22, 2025

hey @bcdurak , I have deleted the duplicate one. merge this pull request.
i have done this pull request from develop.Kindly check and merge it to this Repo

@harsha08-2k6
Copy link
Author

Hey @bcdurak , I solved all the issues , Kindly Merge it to repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants